refactor(mac): Replace deprecated NS{On,Off}State to NSControlStateValue{On,Off} #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR. |
…lue{On,Off}
Signed-off-by: Natsuki Ikeguchi <[email protected]>
siketyan
force-pushed
the
refactor/deprecated-ns-control-state
branch
from
b3cf133
to
d24e9dc
Compare
|
We have been running the internal process to accept your PR. |
|
We have merged this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NSOnStateandNSOffStateare deprecated since 10.14 and should be replaced byNSControlStateValueOnandNSControlStateValueOff. It can be migrated safely since Mozc supports macOS 11.0 and later.Issue IDs
N/A
Steps to test new behaviors (if any)
N/A
Additional context
NSOnState: https://developer.apple.com/documentation/appkit/nsonstate
NSControlStateValueOn: https://developer.apple.com/documentation/appkit/nscontrolstatevalueon