-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Append and fix entries in symbols.tsv #1074
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi tsts-u,
Thank you for your PR!
Please check my comments.
Supports kana input too
Knight is for fortune telling, not for games. https://gamefarm.jp/rule/cego.html https://cardgame.wiki.fc2.com/wiki/%E3%82%BF%E3%83%AD%E3%83%83%E3%83%88%E6%A6%82%E8%AB%96 https://gamefarm.jp/rule/dreierles.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For PRs in future, please refrain from adding the contents in the middle of the review.
Thank you,
I thought it is a little pain of a neck to switch or merge multiple sets of symbols addition. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the update. We are almost there.
Description
Issue IDs
Steps to test new behaviors (if any)
A clear and concise description about how to verify new behaviors (if any).
"
→ Space produces あ゙.(In kana mode) あ → ゛ → Space produces あ゙It's a pain in the buttocks to enumerate all cases in this week. I'll update this in next week.
Additional context
Add any other context about the pull request here.
VS-15 (U+FE0E) is added after Red Dragon and Black Joker.
One or both of Fahrenheit signs can be removed.