Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some reading corrections #1069

Merged
merged 3 commits into from
Oct 8, 2024
Merged

Conversation

tats-u
Copy link
Contributor

@tats-u tats-u commented Oct 6, 2024

Description

A clear and concise description of this pull request.

  • 上側: I've misread this word (controversial)
  • 鶴舞公園 & 千種高等学校: famous for misreading names due to JR stations with same kanji notations.

https://www.nhk.or.jp/nagoya/lreport/article/000/31/
https://crd.ndl.go.jp/reference/entry/index.php?id=1000140124&page=ref_view

Issue IDs

Issue and/or discussion IDs related to this pull request.

Steps to test new behaviors (if any)

A clear and concise description about how to verify new behaviors (if any).

  • OS: [e.g. Windows 11, macOS 13.1, etc] Any
  • Steps:
    • Suggestion appears when you type "うえがw", "つるまいk", and "ちくさこ" (not yet when "うえが", "つるまい", and "ちくさk")

Additional context

Add any other context about the pull request here.

image

Digital Dai Jisen set the reading of "上側" as "うわわ" but it hasn't been registered in Mozc's dictionary.
Meikyo Japanese Dictionary and Iwanami Japanese Dictionary adopt "うわがわ".

"千種高校" is registered only in the proprietary Google Japanese Dictionary, so I don't add it.

Disclaimer: I occasionally use Chikusa & Tsurumai stations but am not an OB of Chigusa High School.

Copy link
Collaborator

@hiroyuki-komatsu hiroyuki-komatsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi tats-u,
Thank you for your PR!

@@ -748,3 +748,6 @@
出音 でおと しゅっとん
琴電 きんでん ことでん
博士課程 はかせかてい はくしかてい
上側 うえがわ うわがわ
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

上側(うえがわ) can be added as a word instead of the correction.
How about removing this line from this PR and focus other corrections?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, even Google Japanese Input doesn't register "上側" as "うえがわ".

  • うわがわ: Both Mozc & Google Japanese Input
  • うわかわ: Only Google Japanese Input
  • うえがわ & うえかわ: Neither

Copy link
Contributor Author

@tats-u tats-u Oct 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither of Digital Dai Jisen or Meikyo Japanese Dictionary register "うえがわ" or "うえかわ".
I have to look into Kojien or Japan Japanese Large Dictionary (日本国語大辞典) (or similar large dictionaries) though.
If even both didn't register either, would you change your opinion?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

People widely use "うえがわ" too. I'd prefer adding it as a word, but not a correction.

https://www.google.com/search?q=%E4%B8%8A%E5%81%B4+%22%E3%81%86%E3%81%88%E3%81%8C%E3%82%8F%22

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kojien and Nihon Kokugo Dai Jiten adopt "うわかわ" ("うわがわ" is an alternative pronunciation).
No "うえがわ" in there.
It's controversial, so I removed it from this PR.

@hiroyuki-komatsu hiroyuki-komatsu merged commit 2e19e74 into google:master Oct 8, 2024
1 check passed
@hiroyuki-komatsu
Copy link
Collaborator

We have merged this PR.
Thank you for the contribution!

@tats-u tats-u deleted the correction branch October 8, 2024 14:02
hiroyuki-komatsu added a commit that referenced this pull request Oct 10, 2024
2.30.5595 → 2.30.5618

Conversion
* Updated zip code entries (#1063).
* Updated word entries (#1068, #1069)

Bug fix
* Linux: Enabled switching to the DIRECT mode from the menu (#1061)
* Linux: Enabled switching modes with Super+Space in Wayland (#853, #1059)
* macOS: Fixed the limitation of mouse clicking on the renderer on macOS 15 (120bd93)
* Windows: Fixed the setting of Omaha updater for the GoogleJapaneseInput build (#1072)

Build
* Android: Switched the Bazel rules from WORKSPACE to Bzlmod (#1002)
* Android: Updated the Docker build environment
* Linux: Update the build environment: Ubuntu 22.04 → 24.04 (#924)
* macOS / Windows: Updated the Qt version: 6.7.2 → 6.7.3 (#1065)
* Windows: Supported Bazel build (#948)
* Windows: Updated the Wix version: 4.0.5 → 5.0.2 (#1070)

Code
* Performed code refactoring

PiperOrigin-RevId: 684295272
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants