Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Add NPM badges for <model-viewer> #4951

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Docs: Add NPM badges for <model-viewer> #4951

merged 1 commit into from
Nov 20, 2024

Conversation

swift502
Copy link
Contributor

@swift502 swift502 commented Nov 19, 2024 •
edited
Loading

Reference Issue

#4942

NPM Badges

I believe these badges will better communicate to users that using model-viewer through NPM is a viable option.

@swift502 swift502 changed the title Add NPM badges Add NPM badges for <model-viewer> Nov 19, 2024
@swift502 swift502 changed the title Add NPM badges for <model-viewer> Docs: Add NPM badges for <model-viewer> Nov 19, 2024
elalish
elalish approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@elalish elalish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, thanks!

@elalish elalish merged commit cc65ec4 into google:master Nov 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elalish elalish elalish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swift502 @elalish