Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create scripts for generating a better prompt context #800

Merged
merged 5 commits into from
Aug 22, 2024
Merged

Create scripts for generating a better prompt context #800

merged 5 commits into from
Aug 22, 2024

Conversation

wwwillchen
Copy link
Collaborator

@wwwillchen wwwillchen commented Aug 15, 2024 •
edited
Loading

Generates a better prompt context by transforming the built (HTML) docs rather than the raw docs.

@wwwillchen wwwillchen changed the title Prompt context enhance Create scripts for generating a better prompt context Aug 22, 2024
@wwwillchen wwwillchen marked this pull request as ready for review August 22, 2024 20:28
richard-to
richard-to approved these changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@richard-to richard-to left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I think you may be able to skip the transform HTML step. I can post a link to some code I have for adding the code snippets and API definitions. Granted, not sure it would be much of an improvement in terms of complexity and final summarized/condensed output.

Also one general question I had was whether this code was for DocBot or for the code gen stuff. Seems like for code gen?

ai/prompt_context/html_docs_context.txt Outdated Show resolved Hide resolved
ai/prompt_context/html_docs_context.txt Outdated Show resolved Hide resolved
ai/prompt_context/html_docs_context.txt Outdated Show resolved Hide resolved
ai/prompt_context/html_docs_context.txt Outdated Show resolved Hide resolved
ai/prompt_context/transform_txt.py Show resolved Hide resolved
@wwwillchen
Copy link
Collaborator Author

LGTM - I think you may be able to skip the transform HTML step. I can post a link to some code I have for adding the code snippets and API definitions. Granted, not sure it would be much of an improvement in terms of complexity and final summarized/condensed output.

Also one general question I had was whether this code was for DocBot or for the code gen stuff. Seems like for code gen?

yeah please share the code for doing the transformations. the transform HTML step isn't great because the output is quite ugly.

@wwwillchen wwwillchen merged commit 0725040 into google:main Aug 22, 2024
2 checks passed
@wwwillchen wwwillchen deleted the prompt_context_enhance branch August 22, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richard-to richard-to richard-to approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wwwillchen @richard-to