Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline theme.scss to avoid deps issue downstream #406

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

wwwillchen
Copy link
Collaborator

  • Having a separate scss file means we need a sass_library target since sass_binary takes in one scss file as an input.
  • Having a sass_library target requires a dependency on the "@angular/material" sass target, however we only have sass_external_binary but not sass_external_library so it's not trivial to have a sass_library with an npm dep like "@angular/material"

There's not much downside with inlining the theme, besides making the styles.scss file a bit longer.

@wwwillchen wwwillchen merged commit 3822f9f into google:main Jun 10, 2024
2 checks passed
wwwillchen added a commit to wwwillchen/mesop that referenced this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant