-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove gulp-shell #790
Comments
As a sidenote, gulp-shell is useful but only when you need to use template strings that are based on the file-name and commands that run per-file. I'll ask them to add that to the README |
It's entirely my fault for letting this pattern land in reviews. Agree we should be just using child_process here. We'll get this fixed up. Thanks for catching this, @contra! |
No problem, just wanted to make sure the google gulpfiles are in good shape because people use them for reference all the time. I can review some of the other ones when I catch a spare minute and send some PRs as well. |
Any feedback regarding the gulpfile is welcome, @contra! Thank you. I plan to do a complete overhaul because it’s become quite organic and convoluted (inefficient, even). |
👍 ✨ |
@surma If you have any questions feel free to ping me on gulp issues, IRC, or twitter whenever |
Closing this as we are moving away from gulp in v2 and there hasn't been much activity on this issue in the past year. If someone would like to contribute the change to the |
https://github.com/google/material-design-lite/blob/master/gulpfile.js#L601 should be replaced with node's built-in child_process module.
gulp.src('').pipe(plugin())
is a really nasty pattern that emerged when people started making plugins for things that shouldn't be plugins.gulp.src('')
will start to error in the final 4.0 release to discourage people from doing thisThe text was updated successfully, but these errors were encountered: