Tab navigation for external links is still broken (#1028 #929)

[kroegerama]

Issues #1028 and #929 still seem to be not properly solved in V1.1.1.
The code seems a little weird. You are adding the EventListener twice. Maybe a merge conflict?

layout.js, line 502:

function MaterialLayoutTab(tab, tabs, panels, layout) {
    /**
     * Auxiliary method to programmatically select a tab in the UI.
     */
    function selectTab() {
        var href = tab.href.split('#')[1];
        var panel = layout.content_.querySelector('#' + href);
        layout.resetTabState_(tabs);
        layout.resetPanelState_(panels);
        tab.classList.add(layout.CssClasses_.IS_ACTIVE);
        panel.classList.add(layout.CssClasses_.IS_ACTIVE);
    }
    if (layout.tabBar_.classList.contains(layout.CssClasses_.JS_RIPPLE_EFFECT)) {
        var rippleContainer = document.createElement('span');
        rippleContainer.classList.add(layout.CssClasses_.RIPPLE_CONTAINER);
        rippleContainer.classList.add(layout.CssClasses_.JS_RIPPLE_EFFECT);
        var ripple = document.createElement('span');
        ripple.classList.add(layout.CssClasses_.RIPPLE);
        rippleContainer.appendChild(ripple);
        tab.appendChild(rippleContainer);
    }
    tab.addEventListener('click', function (e) {
        if (tab.getAttribute('href').charAt(0) === '#') {
            e.preventDefault();
            selectTab();
        }
    });
    tab.show = selectTab;
    tab.addEventListener('click', function (e) {
        e.preventDefault();
        var href = tab.href.split('#')[1];
        var panel = layout.content_.querySelector('#' + href);
        layout.resetTabState_(tabs);
        layout.resetPanelState_(panels);
        tab.classList.add(layout.CssClasses_.IS_ACTIVE);
        panel.classList.add(layout.CssClasses_.IS_ACTIVE);
    });
}

Furthermore, tabs.js, line 130 seems missing the === '#' check.

[VamosErik88]

Any news on this argument? I'm really looking forward for this to be implemented in MDL.

[ross-nordstrom]

It was still broken for me as of v1.1.3 - #4183 (comment), but is easily fixed

[VamosErik88]

@ross-nordstrom how did you fix it? I'd be glad to implement this feature on my project.

[ross-nordstrom]

**Easy to fix within the MDL code. I haven't found a workaround yet...

See the commit @compressed referenced higher up in this thread for how to fix -- basically we just need an if wrapping the tab-clicking logic.

[VamosErik88]

Oh ok got it...
Hope they fix it ASAP ;)