Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could mdl-cell--hide-* be decoupled from cell so we can hide any element. #1162

Closed
SeanBannister opened this issue Jul 22, 2015 · 2 comments
Closed

Comments

@SeanBannister
Copy link
Contributor

I was implementing a header and needed a button to disappear on mobile devices. I was wondering if mdl-cell--hide-phone should be changed to something like mdl-hide-phone so it could fit more use cases. The CSS behind it is display: none !important which is generic enough for wider usage.

Just wanted to open this for discussion.

@Garbee
Copy link
Collaborator

Garbee commented Jul 22, 2015

That is a specific part of the grid system. We don't do any "helper"
classes directly since we are not a framework. Changing names provides
little benefit and may confuse people more as to what the project provides.

If you wish, you can do an extend in a sass build pipeline to trim the name
down.
On Jul 22, 2015 1:16 AM, "Sean Bannister" [email protected] wrote:

I was implementing a header and needed a button to disappear on mobile
devices. I was wondering if mdl-cell--hide-phone should be changed to
something like mdl-hide-phone so it could fit more use cases. The CSS
behind it is display: none !important which is generic enough for wider
usage.

Just wanted to open this for discussion.


Reply to this email directly or view it on GitHub
#1162.

@Garbee
Copy link
Collaborator

Garbee commented Jul 22, 2015

PR #1159 if accepted will introduce names not tied to the cell element naming. I think this is the best we are going to get here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants