Skip to content

Commit

Permalink
Metadata updates for release 8.3.3 (#1629)
Browse files Browse the repository at this point in the history
  • Loading branch information
kkeshava authored Mar 14, 2017
1 parent ab5df26 commit 1f69a99
Show file tree
Hide file tree
Showing 73 changed files with 29,856 additions and 29,717 deletions.
19,831 changes: 9,909 additions & 9,922 deletions cpp/src/phonenumbers/lite_metadata.cc

Large diffs are not rendered by default.

19,699 changes: 9,843 additions & 9,856 deletions cpp/src/phonenumbers/metadata.cc

Large diffs are not rendered by default.

4,096 changes: 2,051 additions & 2,045 deletions cpp/src/phonenumbers/short_metadata.cc

Large diffs are not rendered by default.

Binary file not shown.
Binary file not shown.
Binary file modified java/carrier/src/com/google/i18n/phonenumbers/carrier/data/55_en
Binary file not shown.
Binary file not shown.
Binary file modified java/carrier/src/com/google/i18n/phonenumbers/carrier/data/63_en
Binary file not shown.
Binary file modified java/carrier/src/com/google/i18n/phonenumbers/carrier/data/66_en
Binary file not shown.
Binary file modified java/carrier/src/com/google/i18n/phonenumbers/carrier/data/91_en
Binary file not shown.
Binary file modified java/carrier/src/com/google/i18n/phonenumbers/carrier/data/config
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file modified java/geocoder/src/com/google/i18n/phonenumbers/geocoding/data/84_vi
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
195 changes: 97 additions & 98 deletions javascript/i18n/phonenumbers/demo-compiled.js

Large diffs are not rendered by default.

130 changes: 58 additions & 72 deletions javascript/i18n/phonenumbers/metadata.js

Large diffs are not rendered by default.

130 changes: 58 additions & 72 deletions javascript/i18n/phonenumbers/metadatalite.js

Large diffs are not rendered by default.

4 changes: 1 addition & 3 deletions pending_code_changes.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
Code changes:
- Doc fix for PhoneNumberOfflineGeocoder to explain the cases where an empty
string might be returned.

15 changes: 15 additions & 0 deletions release_notes.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,18 @@
Mar 14, 2017: v8.3.3
Code changes:
- Doc fix for PhoneNumberOfflineGeocoder to explain the cases where an empty
string might be returned.
Metadata changes:
- Updated phone metadata for region code(s):
AG, AI, AS, BB, BF, BM, BQ, BS, BW, CA, DM, DO, ES, GD, GU, HK, HR, IN, JM,
JO, KN, KY, LC, ME, MP, MS, MX, PH, PR, SR, SX, TC, TH, TT, US, VC, VG, VI
- Updated short number metadata for region code(s): ES, HR
- Updated geocoding data for country calling code(s):
34 (en, es), 84 (vi), 91 (en)
- New carrier data for country calling code(s): 264 (en)
- Updated carrier data for country calling code(s):
55 (en), 63 (en), 66 (en), 91 (en), 233 (en), 599 (en)

Feb 28, 2017: v8.3.2
Metadata changes:
- Updated phone metadata for region code(s): BS, CI, HT, IL, IN, IS, KE, SK
Expand Down
Loading

7 comments on commit 1f69a99

@sandheepraj
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Phone number length is failing for Ireland for some of the numbers in cities Arklow, Cork, Dingle where it has 9 digits and currently its allowing only 8 numbers to enter

Let me know

@sandheepraj
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also in Germany some of the cities Bad Homburg and Berlin which has 10 digits and currently length is restricted to 9 digits. Same with Numbers with Nigeria where it has 10 digits and currently it's restricting it to 9.

@keghani
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sandheepraj,

Could you please file issues so we can track those? Please see our contribution guidelines.

@sandheepraj
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where do i have to file?

@keghani
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xiaor186
Copy link

@xiaor186 xiaor186 commented on 1f69a99 Mar 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this commit, some Hong kong numbers aren't valid when call isValidNumber(PhoneNumber number)
in class PhoneNumberUtil, e.g 20775588 is a real number, but isn't valid after this commit.

@kkeshava
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
We can't connect to +852 20775588. Did you have a typo?

As per the numbering plan prefix 207 (8 digits) is not a valid fixedline number, see Pg.16 https://www.ofca.gov.hk/filemanager/ofca/en/content_311/no_plan.pdf

If you still feel it is an issue with the library, please file a bug in Issue Tracker as it will be easy for us to track them. Please share any working numbers or evidence you may have. See our guidelines.

Please sign in to comment.