-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Metadata updates for release 8.3.3 (#1629)
- Loading branch information
Showing
73 changed files
with
29,856 additions
and
29,717 deletions.
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Binary file modified
BIN
+6 Bytes
(100%)
java/carrier/src/com/google/i18n/phonenumbers/carrier/data/233_en
Binary file not shown.
Binary file not shown.
Binary file modified
BIN
-343 Bytes
(99%)
java/carrier/src/com/google/i18n/phonenumbers/carrier/data/55_en
Binary file not shown.
Binary file modified
BIN
-17 Bytes
(95%)
java/carrier/src/com/google/i18n/phonenumbers/carrier/data/599_en
Binary file not shown.
Binary file modified
BIN
+24 Bytes
(110%)
java/carrier/src/com/google/i18n/phonenumbers/carrier/data/63_en
Binary file not shown.
Binary file modified
BIN
+6 Bytes
(100%)
java/carrier/src/com/google/i18n/phonenumbers/carrier/data/66_en
Binary file not shown.
Binary file modified
BIN
+812 Bytes
(100%)
java/carrier/src/com/google/i18n/phonenumbers/carrier/data/91_en
Binary file not shown.
Binary file modified
BIN
+12 Bytes
(100%)
java/carrier/src/com/google/i18n/phonenumbers/carrier/data/config
Binary file not shown.
Binary file modified
BIN
+45 Bytes
(100%)
java/geocoder/src/com/google/i18n/phonenumbers/geocoding/data/34_en
Binary file not shown.
Binary file modified
BIN
+50 Bytes
(120%)
java/geocoder/src/com/google/i18n/phonenumbers/geocoding/data/34_es
Binary file not shown.
Binary file modified
BIN
+267 Bytes
(120%)
java/geocoder/src/com/google/i18n/phonenumbers/geocoding/data/84_vi
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
java/geocoder/src/com/google/i18n/phonenumbers/geocoding/data/91_en
Binary file not shown.
Binary file modified
BIN
+3 Bytes
(100%)
java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_AG
Binary file not shown.
Binary file modified
BIN
+3 Bytes
(100%)
java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_AI
Binary file not shown.
Binary file modified
BIN
+3 Bytes
(100%)
java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_AS
Binary file not shown.
Binary file modified
BIN
+3 Bytes
(100%)
java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_BB
Binary file not shown.
Binary file modified
BIN
-32 Bytes
(93%)
java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_BF
Binary file not shown.
Binary file modified
BIN
+3 Bytes
(100%)
java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_BM
Binary file not shown.
Binary file modified
BIN
+24 Bytes
(110%)
java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_BQ
Binary file not shown.
Binary file modified
BIN
+3 Bytes
(100%)
java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_BS
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_BW
Binary file not shown.
Binary file modified
BIN
+3 Bytes
(100%)
java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_CA
Binary file not shown.
Binary file modified
BIN
+3 Bytes
(100%)
java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_DM
Binary file not shown.
Binary file modified
BIN
+3 Bytes
(100%)
java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_DO
Binary file not shown.
Binary file modified
BIN
-18 Bytes
(98%)
java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_ES
Binary file not shown.
Binary file modified
BIN
+3 Bytes
(100%)
java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_GD
Binary file not shown.
Binary file modified
BIN
+3 Bytes
(100%)
java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_GU
Binary file not shown.
Binary file modified
BIN
+152 Bytes
(120%)
java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_HK
Binary file not shown.
Binary file modified
BIN
-237 Bytes
(80%)
java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_HR
Binary file not shown.
Binary file modified
BIN
-31 Bytes
(99%)
java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_IN
Binary file not shown.
Binary file modified
BIN
+3 Bytes
(100%)
java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_JM
Binary file not shown.
Binary file modified
BIN
+1 Byte
(100%)
java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_JO
Binary file not shown.
Binary file modified
BIN
+3 Bytes
(100%)
java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_KN
Binary file not shown.
Binary file modified
BIN
+3 Bytes
(100%)
java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_KY
Binary file not shown.
Binary file modified
BIN
+3 Bytes
(100%)
java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_LC
Binary file not shown.
Binary file modified
BIN
-137 Bytes
(82%)
java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_ME
Binary file not shown.
Binary file modified
BIN
+3 Bytes
(100%)
java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_MP
Binary file not shown.
Binary file modified
BIN
+3 Bytes
(100%)
java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_MS
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_MX
Binary file not shown.
Binary file modified
BIN
+7 Bytes
(100%)
java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_PH
Binary file not shown.
Binary file modified
BIN
+3 Bytes
(100%)
java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_PR
Binary file not shown.
Binary file modified
BIN
-16 Bytes
(97%)
java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_SR
Binary file not shown.
Binary file modified
BIN
+3 Bytes
(100%)
java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_SX
Binary file not shown.
Binary file modified
BIN
+3 Bytes
(100%)
java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_TC
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_TH
Binary file not shown.
Binary file modified
BIN
+3 Bytes
(100%)
java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_TT
Binary file not shown.
Binary file modified
BIN
+3 Bytes
(100%)
java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_US
Binary file not shown.
Binary file modified
BIN
+3 Bytes
(100%)
java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_VC
Binary file not shown.
Binary file modified
BIN
+3 Bytes
(100%)
java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_VG
Binary file not shown.
Binary file modified
BIN
+3 Bytes
(100%)
java/libphonenumber/src/com/google/i18n/phonenumbers/data/PhoneNumberMetadataProto_VI
Binary file not shown.
Binary file modified
BIN
+63 Bytes
(110%)
java/libphonenumber/src/com/google/i18n/phonenumbers/data/ShortNumberMetadataProto_ES
Binary file not shown.
Binary file modified
BIN
+21 Bytes
(110%)
java/libphonenumber/src/com/google/i18n/phonenumbers/data/ShortNumberMetadataProto_HR
Binary file not shown.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1 @@ | ||
Code changes: | ||
- Doc fix for PhoneNumberOfflineGeocoder to explain the cases where an empty | ||
string might be returned. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
1f69a99
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
Phone number length is failing for Ireland for some of the numbers in cities Arklow, Cork, Dingle where it has 9 digits and currently its allowing only 8 numbers to enter
Let me know
1f69a99
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also in Germany some of the cities Bad Homburg and Berlin which has 10 digits and currently length is restricted to 9 digits. Same with Numbers with Nigeria where it has 10 digits and currently it's restricting it to 9.
1f69a99
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sandheepraj,
Could you please file issues so we can track those? Please see our contribution guidelines.
1f69a99
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where do i have to file?
1f69a99
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can file at https://github.com/googlei18n/libphonenumber/issues/new
1f69a99
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After this commit, some Hong kong numbers aren't valid when call isValidNumber(PhoneNumber number)
in class PhoneNumberUtil, e.g 20775588 is a real number, but isn't valid after this commit.
1f69a99
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
We can't connect to +852 20775588. Did you have a typo?
As per the numbering plan prefix 207 (8 digits) is not a valid fixedline number, see Pg.16 https://www.ofca.gov.hk/filemanager/ofca/en/content_311/no_plan.pdf
If you still feel it is an issue with the library, please file a bug in Issue Tracker as it will be easy for us to track them. Please share any working numbers or evidence you may have. See our guidelines.