-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doesn't compile on windows #363
Comments
There is an old branch for Windows, but it is not an officially supported platform. It's reasonably straightforward to port to Windows. My vote is to make Windows a supported platform at some point, but we need a Windows continuous builder which is not currently supported by Travis CI (travis-ci/travis-ci#2104) |
Regarding CI of Windows builds:
I would be willing to take a stab at a Windows port if you/someone can highlight any major sticky points in the codebase that I need to watch out for pre-port. I have a Windows box to test. |
@cmumford @hitstergtd |
@hcorion |
I'm currently working on a port myself (work in progress), see: https://github.com/andreasbaumann/leveldb I'm backporting the Cmake support from: https://github.com/bureau14/leveldb Having cmake for Windows to generate msbuild or msproject files is just makes life of Windows less painful. :-) This port uses boost for the environment part which is something I would not like to draw in as There is also a native port not using boost: https://github.com/happynear/py-leveldb-windows/ This port also includes a port of snappy to Windows (didn't try myself yet with snappy). The parts to port are:
I got the feeling that code dealing with portability could be cleaned up a little bit: it's spread |
The bitcoin fork of leveldb (https://github.com/bitcoin-core/leveldb) builds for windows but is only updated to v1.18. (My employer has been using an even earlier version of that fork, and we're trying to figure out how to get up-to-date, which is what led me to this issue.) |
This is causing a lot of confusion: people are used to libraries like this being cross-platform, and this one isn’t properly. At the very least, can you please put a note in the README saying “doesn’t work on Windows, see #363”? |
Official support for Windows is probably the most requested enhancement. We are currently working on CMake support with continuous integration. Using issue #466 to track this work. |
Does it support windows installation now? |
Nope. We'll update the README and CI integration when the support lands. |
Hi all,
So, it is a known fact that leveldb does not compile on windows. At one point, there was instructions: http://leveldb.googlecode.com/git-history/windows/WINDOWS but they now no longer work. Someone was maintaining a windows port but it is no longer functioning: http://blog.kowalczyk.info/software/leveldb-for-windows/.
I'm not the only person that has wanted this:
https://ayende.com/blog/161409/leveldb-windows-it-aint-a-love-story
https://groups.google.com/forum/#!topic/leveldb/VuECZMnsob4
https://www.quora.com/How-can-I-compile-and-use-levelDB-for-Windows
So, the need is definitely there, here is what windows has to offer in the ways of building stuff:
cmake (which is actively maintained)
msys2 (which provides GNU make, among others)
MSbuild
nmake (microsoft's version of make)
I would be willing to debug. I have a decently powerful 64-bit windows 10 desktop, I just need a programmer. I have experience with cmake and msys2, and I know my way around a batch (windows script language) script.
The text was updated successfully, but these errors were encountered: