Handle AnnotationTarget.VALUE_PARAMETER for property declarations. #1216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This special handling is needed when an annotation has implicit use site target restriction declared at that annotations declaration site. This is only happening for properties declared in constructor parameter because in constructor parameter, the use site is value parameter which does not violate annotation target contract, and annotations gets carried over to its actual property, therefore need to read the annotation declaration and resolve for targets.
neetopia
force-pushed
the
value-parameter-target
branch
from
b829b23
to
f3fd977
Compare
ting-yuan
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This special handling is needed when an annotation has implicit use site
target restriction declared at that annotations declaration site. This is
only happening for properties declared in constructor parameter because in
constructor parameter, the use site is value parameter which does not violate
annotation target contract, and annotations gets carried over to its actual
property, therefore need to read the annotation declaration and resolve for targets.
The logic is unfortunately, ugly, wonder if there is any utility functions to check it simpler.
fixes #1198