Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KSP2] Annotation value is missing in nested annotations #1833

Closed
kuanyingchou opened this issue Apr 10, 2024 · 4 comments
Closed

[KSP2] Annotation value is missing in nested annotations #1833

kuanyingchou opened this issue Apr 10, 2024 · 4 comments
Assignees
@ting-yuan
Labels
AA waiting for upstream fix bug Something isn't working P1 major features or blocking bugs
Milestone
2.1

Comments

@kuanyingchou
Copy link
Collaborator

This is similar to #1798

The value of nested annotation is null when the origin is KOTLIN_LIB.

Repro: kuanyingchou@f7c01d6
@kuanyingchou kuanyingchou mentioned this issue Apr 11, 2024
Closed
@ting-yuan ting-yuan added bug Something isn't working P1 major features or blocking bugs labels Apr 24, 2024
@ting-yuan ting-yuan added this to the 2.0 milestone Apr 24, 2024
@neetopia neetopia self-assigned this May 7, 2024
@neetopia neetopia added AA waiting for upstream fix and removed AA waiting for upstream fix labels May 7, 2024
@neetopia
Copy link
Contributor

neetopia commented May 7, 2024

The value of the annotation is parsed to be KtUnsupportedAnnotationValue, it requires an upstream fix to allow the parsing of such annotation value.

@neetopia neetopia added the AA waiting for upstream fix label May 8, 2024
@neetopia neetopia modified the milestones: 2.0, 2.1 May 8, 2024
@neetopia neetopia mentioned this issue Jun 6, 2024
Open
@stevenzeck
Copy link

@neetopia where upstream is the fix required?

@neetopia neetopia assigned ting-yuan and unassigned neetopia Jun 25, 2024
@neetopia
Copy link
Contributor

pending https://youtrack.jetbrains.com/issue/KT-68981

@ting-yuan
Copy link
Collaborator

ting-yuan commented Jul 12, 2024 •
edited
Loading

This should be fixed in Analysis API a few hours ago: https://youtrack.jetbrains.com/issue/KT-69761.

ting-yuan added a commit to ting-yuan/ksp that referenced this issue Jul 25, 2024
@ting-yuan
Test case for type annotation on libs
9e40347 
for google#1833
ting-yuan added a commit that referenced this issue Jul 30, 2024
@ting-yuan
Test case for type annotation on libs
192e312 
for #1833
github-actions bot pushed a commit that referenced this issue Jul 30, 2024
@ting-yuan
Test case for type annotation on libs
e0e5277 
for #1833

(cherry picked from commit 192e312)
@kuanyingchou kuanyingchou mentioned this issue Sep 5, 2024
Closed
github-actions bot pushed a commit that referenced this issue Sep 5, 2024
@ting-yuan
Test case for type annotation on libs
546ac48 
for #1833

(cherry picked from commit 192e312)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ting-yuan ting-yuan

Labels
AA waiting for upstream fix bug Something isn't working P1 major features or blocking bugs
Projects
None yet
Milestone
2.1
Development

No branches or pull requests
4 participants
@kuanyingchou @ting-yuan @neetopia @stevenzeck