This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
Ensure VRF uniqueness #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcb82
reviewed
Apr 26, 2017
core/crypto/vrf/p256/p256.go
Outdated
| // G is the base point | ||
| // s = H2(m, [r]G, [r]H) | ||
| // s = H2(m, [r]G, [r]H, [k]H) |
There was a problem hiding this comment.
Order is not following either the CONIKs paper or Franklin paper (which list [k]H earlier)
Also, why not hash in G (base point) and the public key kG? As is done in both papers
There was a problem hiding this comment.
Added the base point and the public key.
Updated the order to match the CONIKS paper.
Codecov Report
@@ Coverage Diff @@
## master #568 +/- ##
==========================================
+ Coverage 57.21% 57.24% +0.03%
==========================================
Files 35 35
Lines 2489 2491 +2
==========================================
+ Hits 1424 1426 +2
Misses 776 776
Partials 289 289
Continue to review full report at Codecov.
|
gdbelvin
force-pushed
the
vrf-fix
branch
2 times, most recently
from
804ecec
to
e04d45f
Compare
gdbelvin
force-pushed
the
vrf-fix
branch
4 times, most recently
from
f729569
to
f4e17a7
Compare
Fixes google#567 VRF uniqueness could be violated because the VRF output itself was not included in the the computation of `s`, the commitment to the VRF and zero knowledge proof.
gdbelvin
force-pushed
the
vrf-fix
branch
2 times, most recently
from
228d7a0
to
2f9ae65
Compare
cryptosubtlety
approved these changes
Jun 21, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VRF uniqueness could be violated because the VRF output itself was not
included in the the computation of
s, the commitment to the VRF andzero knowledge proof. Fixes #567.
Other changes also included in this PR:
References: