Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow use of URL-namespaced claims #94

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Allow use of URL-namespaced claims #94

wants to merge 2 commits into from

Commits on Mar 28, 2023

  1. Fixes for check-style of existing code 

    Kept as a separate commit to avoid complicating the review
    @willthames
    willthames committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    840cc21 View commit details
    Browse the repository at this point in the history

  2. Allow use of URL-namespaced claims 

    Private namespaced claims are recommended to be prefixed with URLs,
but having dots in domain names means that working out nested key
structure by splitting on dots doesn't work.

Instead we assume that if a claim starts with http:// or https://
then everything up to the third slash is part of the top-level key

So https://example.com/nested.claims.key gets treated as
https://example.com/nested -> claims -> key
    @willthames
    willthames committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    80c042d View commit details
    Browse the repository at this point in the history