Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bazel): add MODULE.bazel files for bzlmod #103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mmorel-35
Copy link

I created bazelbuild/bazel-central-registry#2016

This provides the bzlmod

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mmorel-35

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Hi @mmorel-35. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mmorel-35 mmorel-35 marked this pull request as ready for review May 15, 2024 09:44
fmeum pushed a commit to bazelbuild/bazel-central-registry that referenced this pull request May 16, 2024
aiuto pushed a commit to aiuto/bazel-central-registry that referenced this pull request Jun 3, 2024
zaucy pushed a commit to zaucy/bazel-central-registry that referenced this pull request Jun 14, 2024
@mmorel-35
Copy link
Author

mmorel-35 commented Jul 1, 2024

@qiwzhang, @nareddyt, @orionHong,

Anyone can review this?

@orionHong
Copy link
Contributor

@qiwzhang, @nareddyt, @orionHong,

Anyone can review this?

thanks for making the change, but unfortunately, I don't think any of us can stamp it now. maybe @TAOXUY can help route to the right person ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants