Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make CI run as non-root #20

Merged
merged 3 commits into from
Jan 9, 2018
Merged

chore: make CI run as non-root #20

merged 3 commits into from
Jan 9, 2018

Conversation

jinwoo
Copy link
Member

@jinwoo jinwoo commented Jan 9, 2018

Hopefully this will fix the auto-NPM-publishing. Currently the prepare
phase fails.

Hopefully this will fix the auto-NPM-publishing. Currently the `prepare`
phase fails.
@jinwoo jinwoo requested review from ofrobots and a team January 9, 2018 22:54
@codecov-io
Copy link

codecov-io commented Jan 9, 2018

Codecov Report

Merging #20 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #20   +/-   ##
=======================================
  Coverage   81.57%   81.57%           
=======================================
  Files           4        4           
  Lines         331      331           
  Branches       70       70           
=======================================
  Hits          270      270           
  Misses         61       61

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c8db11...d48a911. Read the comment docs.

@jinwoo
Copy link
Member Author

jinwoo commented Jan 9, 2018

Piggybacking the version update change so that I can publish new NPM right after this.

@jinwoo
Copy link
Member Author

jinwoo commented Jan 9, 2018

Also adding the files stanza to package.json so that unnecessary files are not included in the NPM package.

Copy link

@kjin kjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jinwoo jinwoo merged commit 6b7c704 into google:master Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants