Update guava-jre instead of guava-android.
#255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_543516882
branch
from
3b774b2 to
a236f6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
guava-jreinstead ofguava-android.Since both flavors of Guava require Java 8+ nowadays (as will jimfs), I don't think there's an advantage of using
guava-android.I suppose that I could look into how much of
java.file.niocan work under new versions of Android or with desugaring. (Notably, do custom file systems work at all?) But my guess is that, in general, any Android code that can usejava.file.niocan useguava-jre—though perhaps it shouldn't do either of those things :)RELNOTES=n/a