Target Java 8: #241
Closed
Target Java 8: #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_535378262
branch
from
faaa4a6 to
5b60a42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target Java 8:
-source 8 -target 8. We already have a depencdency onguava-android, which began requiring Java 8 a while back, so we might as well unlock the ability to use Java 8 language features ourselves. (I also found I had to set-source 8inmaven-javadoc-pluginto prevent it from trying to pass a--module-path, which leads to problems with our usages of@NullableDecl, which isn't in a module. That's probably unrelated: We probably just haven't run Javadoc since somemaven-javadoc-pluginupgrade.) Work toward Bump guava.version from 31.1-android to 32.0.0-android #240, and fixes Drop Java 7 compatibility #229ByteBuffermethods, and set up Error Prone enforcement of future such mistakes. Compare Enable [Java8ApiChecker](https://errorprone.info/bugpattern/Java8ApiChecker) for Maven builds. guava#6334. Fixes Check for problems with ByteBuffer covariant return types when building with JDK 9+ #113RELNOTES=Officially dropped support for Java 7, and restored accidentally dropped support for Java 8.