Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix order of columnState param #830

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Fix order of columnState param #830

merged 1 commit into from
Dec 13, 2022

Conversation

luizgrp
Copy link
Member

@luizgrp luizgrp commented Dec 13, 2022

WHAT

Fix order of columnState param in composables.

WHY

Modifier should appear as the first optional parameter in the parameter list; after all required parameters (except for trailing lambda parameters) but before any other parameters with default values.

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@luizgrp luizgrp self-assigned this Dec 13, 2022
@luizgrp luizgrp force-pushed the fix_columnstate_order branch from 1c00b47 to 68800e9 Compare December 13, 2022 10:59
@luizgrp luizgrp mentioned this pull request Dec 13, 2022
Closed
@luizgrp luizgrp force-pushed the fix_columnstate_order branch from 68800e9 to 6ec4d96 Compare December 13, 2022 11:54
@luizgrp luizgrp requested a review from yschimke December 13, 2022 12:46
luizgrp
luizgrp commented Dec 13, 2022
View reviewed changes
...-layout/src/main/java/com/google/android/horologist/compose/layout/ScalingLazyColumnState.kt
columnState: ScalingLazyColumnState,
modifier: Modifier = Modifier,
Copy link
Member Author

@luizgrp luizgrp Dec 13, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yschimke are you happy with this change? highlighting it as this composable is not marked as experimental

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably should be. Can you add?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will add in another PR as I have another branch chained to this one

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are loads of classes in compose-layout without the experimental annotation. Should I apply it to all or just this one?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#837

@luizgrp luizgrp merged commit c0ce58b into google:main Dec 13, 2022
@luizgrp luizgrp deleted the fix_columnstate_order branch December 13, 2022 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yschimke yschimke yschimke approved these changes

Assignees

@luizgrp luizgrp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luizgrp @yschimke