Add twitter compose rules ktlint check #610
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Run Twitter's Jetpack Compose Rules in CI.
WHY
In order to improve quality of project's composables.
HOW
Add plugin via kolinter given it's not currently working with spotless. Given it might be potentially doing duplicated work and increasing build time, we might decide to only add it to the project once it's supported by spotless.
RESULTS
A lot of findings in composables functions in preview files, test files, and sample apps, which we should filter out for those rules.
modifier-missing-check
in many functions.param-order-check
inWearNavScaffold
,SegmentedProgressIndicator
,FillerScreen
,BigScalingLazyColumn
,BigColumn
,MediaPlayerScaffold
,StandardChip
and other internal functions.modifier-reused-check
inPlayPauseButton
(seems to be intended?).twitter-compose:multiple-emitters-check
inTimePicker
.Checklist 📋