Demonstrate an alternative architectural approach #2431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with the Media3 `Player` interface.
|
This looks promising. If you go to https://github.com/JolandaVerhoef/horologist/actions/workflows/fixup.yml, and run against your branch, it should fix API, screenshots and some lint. |
yschimke
reviewed
Oct 23, 2024
...e/src/main/java/com/google/android/horologist/mediasample/ui/player/UampMediaPlayerScreen.kt
Outdated
Show resolved
Hide resolved
media/sample/src/main/java/com/google/android/horologist/mediasample/ui/app/UampWearApp.kt
Outdated
Show resolved
Hide resolved
|
@JolandaVerhoef nice, this is looking promising. |
yschimke
reviewed
Nov 15, 2024
| ) { | ||
| val player: Player? by newHotnessPlayerScreenViewModel.player.collectAsStateWithLifecycle() | ||
| val player by experimentalUiModePlayerScreenViewModel.player.collectAsStateWithLifecycle() |
There was a problem hiding this comment.
I feel like we should use the null pattern* to handle this outside the screen. And rely on the ViewModel to cache the current player on resuming the player activity.
So it's never null, you can always show something, but no media will be shown, no actions enabled, and the screen can check and use that as a loading state if it wants.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Approach is hard-linked with the Media3
Playerinterface.WHAT
WHY
HOW
Checklist 📋