Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Card Padding #2284

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Fix Card Padding #2284

merged 2 commits into from
Jul 1, 2024

Conversation

yschimke
Copy link
Collaborator

@yschimke yschimke commented Jul 1, 2024

WHAT

Fix Card Padding and add tests.

WHY

Was showing incorrectly when onLongClick was missing.

HOW

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@yschimke
Copy link
Collaborator Author

yschimke commented Jul 1, 2024

Comparison with the bug

image

@yschimke
Copy link
Collaborator Author

yschimke commented Jul 1, 2024

cc @amankhoza

@yschimke yschimke closed this Jul 1, 2024
@yschimke yschimke reopened this Jul 1, 2024
Copy link
Collaborator

@amankhoza amankhoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me, might not be worth fixing but worth noting screenshots look like the padding across buttons with and w/o longClick is still slightly inconsistent.

@yschimke
Copy link
Collaborator Author

yschimke commented Jul 1, 2024

@amankhoza I think that's the custom padding vs standard padding. If not, maybe attach a picture or video of the diff.

@yschimke yschimke merged commit 65db42c into google:main Jul 1, 2024
6 checks passed
@amankhoza
Copy link
Collaborator

Ah yes you're right it is just the custom padding.

@yschimke yschimke deleted the fid_card branch August 23, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants