Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picker #180

Merged
merged 5 commits into from
May 18, 2022
Merged

Picker #180

merged 5 commits into from
May 18, 2022

Conversation

JohnNichol
Copy link
Collaborator

WHAT

Update the kotlin gradle and kapt plugins to take version from kotlin variable.

WHY

Keep the versions in sync - #171

HOW

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

John Nichol added 3 commits May 13, 2022 17:39
Add missing KDoc
Replace hardcoded strings with stringResources.
Add missing KDoc
Replace hardcoded strings with stringResources.
@JohnNichol JohnNichol requested a review from yschimke May 18, 2022 13:42
Copy link
Member

@luizgrp luizgrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the tidy up 👍

@JohnNichol JohnNichol merged commit d29eed9 into google:main May 18, 2022
@JohnNichol JohnNichol deleted the picker branch May 18, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants