Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve PlayerRepository and fix MediaItemPosition #175

Merged
merged 1 commit into from
May 17, 2022
Merged

Improve PlayerRepository and fix MediaItemPosition #175

merged 1 commit into from
May 17, 2022

Conversation

luizgrp
Copy link
Member

@luizgrp luizgrp commented May 17, 2022 •
edited
Loading

WHAT

Improve PlayerRepository and fix MediaItemPosition.

HOW

  • Add play at given index function to PlayerRepository;
  • Change return type of getSeekBackIncrement and getSeekForwardIncrement to Duration in PlayerRepository;
  • Fix checks in MediaItemPosition and add tests;
  • Update source/target compatibility of media module to java8;

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@luizgrp luizgrp force-pushed the media_improveapi branch 2 times, most recently from ce522da to 26700a3 Compare May 17, 2022 15:49
@luizgrp luizgrp merged commit 9629022 into google:main May 17, 2022
@luizgrp luizgrp deleted the media_improveapi branch May 17, 2022 16:22
@luizgrp luizgrp self-assigned this Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yschimke yschimke yschimke approved these changes

Assignees

@luizgrp luizgrp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luizgrp @yschimke