Improve StandardToggleChip to handle largest font scale #1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yschimke
reviewed
May 17, 2023
| @@ -49,7 +51,7 @@ import com.google.android.horologist.base.ui.util.DECORATIVE_ELEMENT_CONTENT_DES | |||
| @Composable | |||
| public fun StandardToggleChip( | |||
| checked: Boolean, | |||
| onCheckedChange: (Boolean) -> Unit, | |||
| onCheckedChanged: (Boolean) -> Unit, | |||
There was a problem hiding this comment.
Why past tense? Shouldn't we match the ToggleChip?
There was a problem hiding this comment.
My interpretation is that the callback is called after the event has performed. Can revert in the future once figure out that is not the case!
yschimke
approved these changes
May 17, 2023
56 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Improve
StandardToggleChipto handle largest font scale.WHY
So it won't clip the text when user is using largest font scale.
HOW
Checklist 📋