-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zhoozh up the readme #121
Zhoozh up the readme #121
Conversation
@yschimke PR description is 🔝 🔝 🔝 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some suggestion - PTAL, let me know if you think that using emoji is too much
@@ -4,25 +4,50 @@ Horologist is a labs like environment for new Wear APIs. We use it to help fill | |||
|
|||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing whole paragraph.
|
||
Kotlin favoured coroutines. | ||
Domain model for Media Player. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why capital letters? isn't it for any media player? otherwise it's imply use of https://developer.android.com/reference/android/media/MediaPlayer
@@ -4,25 +4,50 @@ Horologist is a labs like environment for new Wear APIs. We use it to help fill | |||
|
|||
--- | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re Compose/Compose for Wear OS versions - will this be includes in each library? (I'm looking at https://github.com/google/accompanist#compose-versions)
@@ -4,25 +4,50 @@ Horologist is a labs like environment for new Wear APIs. We use it to help fill | |||
|
|||
--- | |||
|
|||
## Tiles | |||
## Media UI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add 🎵 ?
|
||
<img src="https://github.com/google/horologist/blob/6b4a07a4d5cf010838b151e345860dca92c5490a/docs/composables/time_12h_picker.png" height="120" width="120" > | ||
|
||
<img src="https://github.com/google/horologist/blob/6b4a07a4d5cf010838b151e345860dca92c5490a/docs/composables/time_24h_picker.png" height="120" width="120" > | ||
|
||
## Compose Layout |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add 📐 or 🧭 🔗?
|
||
<img src="https://github.com/google/horologist/blob/6b4a07a4d5cf010838b151e345860dca92c5490a/docs/composables/time_12h_picker.png" height="120" width="120" > | ||
|
||
<img src="https://github.com/google/horologist/blob/6b4a07a4d5cf010838b151e345860dca92c5490a/docs/composables/time_24h_picker.png" height="120" width="120" > | ||
|
||
## Compose Layout | ||
|
||
Layout related functionality such as a Navigation Aware Scaffold. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a brief explanation about benefits?
|
||
<img src="https://github.com/google/horologist/blob/6b4a07a4d5cf010838b151e345860dca92c5490a/docs/compose-layout/fill_max_rectangle.png" height="120" width="120" > | ||
|
||
<img src="https://github.com/google/horologist/blob/6b4a07a4d5cf010838b151e345860dca92c5490a/docs/compose-layout/fade_away.png" height="120" width="120" > | ||
|
||
## Audio and UI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add 🔊 ?
|
||
<img src="https://github.com/google/horologist/blob/6b4a07a4d5cf010838b151e345860dca92c5490a/docs/audio-ui/volume_screen.png" height="120" width="120" > | ||
|
||
## Tiles |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about 🪄 ?
[horologist-compose-layout](./compose-layout) | ||
- [horologist-compose-layout](./compose-layout) | ||
|
||
<img src="https://github.com/google/horologist/blob/6b4a07a4d5cf010838b151e345860dca92c5490a/docs/compose-layout/fill_max_rectangle.png" height="120" width="120" > |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found this images a bit confusing unless there is some explanation, first one looks like a box layout
|
||
- [horologist-composables](./composables) | ||
|
||
<img src="https://github.com/google/horologist/blob/6b4a07a4d5cf010838b151e345860dca92c5490a/docs/composables/date_picker.png" height="120" width="120" > |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe try to fit all three into a single line?
WHAT
Zhoozh up the readme
WHY
It's boring an unexciting
HOW
Images, baby!