Zhoozh up the readme #121
Merged
Zhoozh up the readme #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yschimke PR description is 🔝 🔝 🔝 😄 |
shumelchyk
reviewed
May 9, 2022
| @@ -4,25 +4,50 @@ Horologist is a labs like environment for new Wear APIs. We use it to help fill | |||
|
|
|||
| --- | |||
There was a problem hiding this comment.
Removing whole paragraph.
|
|
||
| Kotlin favoured coroutines. | ||
| Domain model for Media Player. |
There was a problem hiding this comment.
why capital letters? isn't it for any media player? otherwise it's imply use of https://developer.android.com/reference/android/media/MediaPlayer
| @@ -4,25 +4,50 @@ Horologist is a labs like environment for new Wear APIs. We use it to help fill | |||
|
|
|||
| --- | |||
|
|
|||
There was a problem hiding this comment.
Re Compose/Compose for Wear OS versions - will this be includes in each library? (I'm looking at https://github.com/google/accompanist#compose-versions)
| @@ -4,25 +4,50 @@ Horologist is a labs like environment for new Wear APIs. We use it to help fill | |||
|
|
|||
| --- | |||
|
|
|||
| ## Tiles | |||
| ## Media UI | |||
|
|
||
| <img src="https://github.com/google/horologist/blob/6b4a07a4d5cf010838b151e345860dca92c5490a/docs/composables/time_12h_picker.png" height="120" width="120" > | ||
|
|
||
| <img src="https://github.com/google/horologist/blob/6b4a07a4d5cf010838b151e345860dca92c5490a/docs/composables/time_24h_picker.png" height="120" width="120" > | ||
|
|
||
| ## Compose Layout |
|
|
||
| <img src="https://github.com/google/horologist/blob/6b4a07a4d5cf010838b151e345860dca92c5490a/docs/composables/time_12h_picker.png" height="120" width="120" > | ||
|
|
||
| <img src="https://github.com/google/horologist/blob/6b4a07a4d5cf010838b151e345860dca92c5490a/docs/composables/time_24h_picker.png" height="120" width="120" > | ||
|
|
||
| ## Compose Layout | ||
|
|
||
| Layout related functionality such as a Navigation Aware Scaffold. |
There was a problem hiding this comment.
Can you add a brief explanation about benefits?
|
|
||
| <img src="https://github.com/google/horologist/blob/6b4a07a4d5cf010838b151e345860dca92c5490a/docs/compose-layout/fill_max_rectangle.png" height="120" width="120" > | ||
|
|
||
| <img src="https://github.com/google/horologist/blob/6b4a07a4d5cf010838b151e345860dca92c5490a/docs/compose-layout/fade_away.png" height="120" width="120" > | ||
|
|
||
| ## Audio and UI |
|
|
||
| <img src="https://github.com/google/horologist/blob/6b4a07a4d5cf010838b151e345860dca92c5490a/docs/audio-ui/volume_screen.png" height="120" width="120" > | ||
|
|
||
| ## Tiles |
| [horologist-compose-layout](./compose-layout) | ||
| - [horologist-compose-layout](./compose-layout) | ||
|
|
||
| <img src="https://github.com/google/horologist/blob/6b4a07a4d5cf010838b151e345860dca92c5490a/docs/compose-layout/fill_max_rectangle.png" height="120" width="120" > |
There was a problem hiding this comment.
I found this images a bit confusing unless there is some explanation, first one looks like a box layout
|
|
||
| - [horologist-composables](./composables) | ||
|
|
||
| <img src="https://github.com/google/horologist/blob/6b4a07a4d5cf010838b151e345860dca92c5490a/docs/composables/date_picker.png" height="120" width="120" > |
There was a problem hiding this comment.
Maybe try to fit all three into a single line?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Zhoozh up the readme
WHY
It's boring an unexciting
HOW
Images, baby!