Remove bottom padding from SignedInConfirmationDialog (#1562)

google · Aug 8, 2023 · b3885a7 · b3885a7
1 parent 5ae151c
commit b3885a7
Show file tree

Hide file tree

Showing 7 changed files with 13 additions and 16 deletions.
diff --git a/...java/com/google/android/horologist/auth/composables/dialogs/SignedInConfirmationDialog.kt b/...java/com/google/android/horologist/auth/composables/dialogs/SignedInConfirmationDialog.kt
@@ -50,7 +50,6 @@ import java.time.Duration
 
 private const val AVATAR_BACKGROUND_COLOR = 0xFF4ECDE6
 private const val AVATAR_TEXT_COLOR = 0xFF202124
-private const val BOTTOM_PADDING_SCREEN_PERCENTAGE = 0.094
 private const val HORIZONTAL_PADDING_SCREEN_PERCENTAGE = 0.094
 
 /**
@@ -113,13 +112,11 @@ internal fun SignedInConfirmationDialogContent(
 ) {
     val configuration = LocalConfiguration.current
     val horizontalPadding = (configuration.screenWidthDp * HORIZONTAL_PADDING_SCREEN_PERCENTAGE).dp
-    val bottomPadding = (configuration.screenHeightDp * BOTTOM_PADDING_SCREEN_PERCENTAGE).dp
 
     Column(
         modifier = modifier
             .fillMaxSize()
-            .padding(horizontal = horizontalPadding)
-            .padding(bottom = bottomPadding),
+            .padding(horizontal = horizontalPadding),
         verticalArrangement = Arrangement.Center,
         horizontalAlignment = Alignment.CenterHorizontally
     ) {

diff --git a/...mposables.dialogs_SignedInConfirmationDialogTest_signedInConfirmationDialog.png b/...mposables.dialogs_SignedInConfirmationDialogTest_signedInConfirmationDialog.png
diff --git a/...es.dialogs_SignedInConfirmationDialogTest_signedInConfirmationDialogNoEmail.png b/...es.dialogs_SignedInConfirmationDialogTest_signedInConfirmationDialogNoEmail.png
diff --git a/...logs_SignedInConfirmationDialogTest_signedInConfirmationDialogNoInformation.png b/...logs_SignedInConfirmationDialogTest_signedInConfirmationDialogNoInformation.png
diff --git a/...les.dialogs_SignedInConfirmationDialogTest_signedInConfirmationDialogNoName.png b/...les.dialogs_SignedInConfirmationDialogTest_signedInConfirmationDialogNoName.png
diff --git a/...ogs_SignedInConfirmationDialogTest_signedInConfirmationDialogNoNameNoAvatar.png b/...ogs_SignedInConfirmationDialogTest_signedInConfirmationDialogNoNameNoAvatar.png
diff --git a/...dialogs_SignedInConfirmationDialogTest_signedInConfirmationDialogTruncation.png b/...dialogs_SignedInConfirmationDialogTest_signedInConfirmationDialogTruncation.png