Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add -lpthread to guetzli.make #15

Closed
wants to merge 2 commits into from
Closed

add -lpthread to guetzli.make #15

wants to merge 2 commits into from

Conversation

shrx
Copy link

@shrx shrx commented Jan 12, 2017

Fixes #14

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@robryk
Copy link
Contributor

robryk commented Jan 12, 2017

This file is generated by premake. Would you mind adding the change to premake5.lua in the list where -lz is present and regenerating this file using premake?

@shrx
Copy link
Author

shrx commented Jan 12, 2017

I updated the file premake5.lua, however I am not familiar with premake so I don't know the procedure to regenerate using the modification.

@robryk
Copy link
Contributor

robryk commented Jan 16, 2017

I am terribly sorry, but signing a CLA is a hard requirement for legal reasons. Likewise the requirement that you provide an address and a contact phone when doing so.

I shan't merge a patch for which that is not satisfied. Sorry again.

@robryk robryk closed this Jan 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants