Moe Sync #3519
Moe Sync #3519
Conversation
We were previously apparently inheriting them from sonatype-oss-parent, until we removed that. Releases don't work without a description. "Invalid POM: /com/google/guava/guava-parent/28.0-android/guava-parent-28.0-android.pom: Project description missing" ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=252733039
Fixes #3500 RELNOTES=n/a ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=252852929
…eir common supertype, ReflectiveOperationException. ReflectiveOperationException isn't available on the old versions of Android that we support. As far as we know, there is no actual problem with these references because no methods are called on them. However, the new version of Animal Sniffer we're updating to will flag them anyway, and I think that avoiding them is the safe thing to do. Prepares for #3497 RELNOTES=n/a ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=252888170
Fixes #3497 RELNOTES=n/a ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=252891687
RELNOTES=n/a ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=252895367
RELNOTES=Use saturatedToNanos() in CacheBuilder to avoid overflows. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=253341058
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=253664020
RELNOTES=Add more @nullables to variadic parameter lists. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=254718073
AtomicLongArray(long[]) clones its input, which is a waste when we're passing in a new array. RELNOTES=Halve VmPeak when creating a Bloom filter. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=254770497
Fixes #3503 RELNOTES=avoid overflows/underflows in CacheStats ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=254899180
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=255595656
ronshapiro
added
the
internal-sync
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
|
@kluever I think you missed an overflow check in |
This code has been reviewed and submitted internally. Feel free to discuss on the PR and we can submit follow-up changes as necessary.
Commits:
Add missing description tags to guava-parent poms.
We were previously apparently inheriting them from sonatype-oss-parent, until we removed that. Releases don't work without a description. "Invalid POM: /com/google/guava/guava-parent/28.0-android/guava-parent-28.0-android.pom: Project description missing"
c417618
Fix typo in 'stoppingCount' variable name
Fixes #3500
c168ba2
Split catch() blocks so that javac doesn't generate a reference to their common supertype, ReflectiveOperationException.
ReflectiveOperationException isn't available on the old versions of Android that we support.
As far as we know, there is no actual problem with these references because no methods are called on them. However, the new version of Animal Sniffer we're updating to will flag them anyway, and I think that avoiding them is the safe thing to do.
Prepares for #3497
15c9a93
Upgrade animal sniffer version to 1.18
Fixes #3497
afdecf7
Document default values of builder setters.
d5dca36
Use saturatedToNanos() in CacheBuilder to avoid overflows.
RELNOTES=Use saturatedToNanos() in CacheBuilder to avoid overflows.
7d04f72
Tweaks to the list of Guava features.
4dbc7c1
Add more @nullables to variadic parameter lists.
RELNOTES=Add more @nullables to variadic parameter lists.
fbae3f4
Halve memory consumption when creating a Bloom filter.
AtomicLongArray(long[]) clones its input, which is a waste when we're passing
in a new array.
RELNOTES=Halve VmPeak when creating a Bloom filter.
f499820
Use LongMath.saturatedAdd/Subtract in CacheStats.
Fixes #3503
RELNOTES=avoid overflows/underflows in CacheStats
9f3d048
Fix the travis build
ba4111c