-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give FieldNamingStrategy the ability to return multiple String names #2776
base: main
Are you sure you want to change the base?
Conversation
Thanks for this suggestion! It seems that would resolve #1002 However, we cannot change the return type of This is just an idea though, maybe there are other possible approaches. |
@Marcono1234 Great idea. I wasn't sure what the best approach would be. I'll review your suggestion and see if I can get it to work. |
3bc670e
to
0d769c7
Compare
0d769c7
to
94c9ea2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes!
The build currently fails due to formatting violations. You can solve this by running mvn spotless:apply
.
Also note that the commits are squashed on merge here, so you don't have to force-push / rewrite commits, but instead can incrementally make changes to this pull request.
@eamonnmcmanus what do you think about these proposed changes?
gson/src/main/java/com/google/gson/internal/bind/ReflectiveTypeAdapterFactory.java
Outdated
Show resolved
Hide resolved
- Changed fieldName to be added first to the fieldName list - test which verifies that when 'alternate names' are configured they don't affect serialization, and only affect deserialization - Updated translateToAlternateNames JavaDoc to refer it works like SerializedName#alternate()
Check Android compatibility test fails when using Stream.concat, switched to traditional Java method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your changes! A few more small points, but looks good besides that.
We will however have to wait for the opinion and review from a direct Gson maintainer then.
1. Renamed badname to primary-name 2. Added test deserializing TranslateName with translateToAlternateNames
Purpose
This pull request enhances the
FieldNamingStrategy
in Gson to support returning multiple strings for a field name. This behavior aligns with the alternate names functionality provided by the@SerializedName
annotation, allowing for greater flexibility in field mapping.Description
The
FieldNamingStrategy
interface has been updated to allow implementations to return a list of potential field name mappings. This allows deserialization to succeed if any of the alternate names are present in the JSON data.The changes include is to modifying the
FieldNamingStrategy
interface to support returning a collection of names. This allows theFieldNamingStrategy
interface to behave like the@SerializedName
annotation.Checklist
This is automatically checked by
mvn verify
, but can also be checked on its own usingmvn spotless:check
.Style violations can be fixed using
mvn spotless:apply
; this can be done in a separate commit to verify that it did not cause undesired changes.null
@since $next-version$
(
$next-version$
is a special placeholder which is automatically replaced during release)TestCase
)mvn clean verify javadoc:jar
passes without errors