Prevent Java deserialization of internal classes #1991
Merged
+83
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adversaries might be able to forge data which can be abused for DoS attacks. These classes are already writing a replacement JDK object during serialization for a long time, so this change should not cause any issues.
|
This makes sense. Thanks! |
Marcono1234
deleted the
marcono1234/java-deserialization-internal-classes
branch
sakibguy
added a commit
to sakibguy/gson
that referenced
this pull request
Oct 14, 2021
Prevent Java deserialization of internal classes (google#1991)
This was referenced Nov 11, 2021
This was referenced Nov 12, 2021
Closed
This was referenced Aug 24, 2024
This was referenced Sep 18, 2024
This was referenced Oct 18, 2024
This was referenced Oct 26, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Edit: See #1991 (comment) below for a more in-depth description of the impact.
Adversaries might be able to forge data which can be abused for DoS attacks.
These classes are already writing a replacement JDK object through
writeReplace()during serialization for a long time (multiple years), so this change should not cause any issues.I have not added tests for the prevented deserialization because it would require hardcoding the binary deserialization data which would decrease transparency of this project.