agent: fix mistakes in off-heap mstat naming #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some statistics were mislabeled as related to the stack while those are off-heap memory statistics. I'm guessing this is due to their proximity with the stack stats. Here is the general documentation for these metrics: https://github.com/golang/go/blob/go1.23.2/src/runtime/mstats.go#L209-L218 // Off-heap memory statistics. // // The following statistics measure runtime-internal // structures that are not allocated from heap memory (usually // because they are part of implementing the heap). Unlike // heap or stack memory, any memory allocated to these // structures is dedicated to these structures. // // These are primarily useful for debugging runtime memory // overheads.> Fixes: 390a413 ("Report more Stack info, as stack-mspan-inuse stack-mspan-sys etc. (google#63)") Signed-off-by: Mahe Tardy <[email protected]>
Since I renamed these fields in the previous commit, let's take this opportunity to be consistent with the other fields containing 'in use'. Signed-off-by: Mahe Tardy <[email protected]>
All off-heap metrics are returned by MemStats except this one so let's add it to have a better global picture of off-heap memory use. Signed-off-by: Mahe Tardy <[email protected]>
tklauser
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some statistics were mislabeled as related to the stack while those are
off-heap memory statistics. I'm guessing this is due to their proximity
with the stack stats.
Here is the general documentation for these metrics:
https://github.com/golang/go/blob/go1.23.2/src/runtime/mstats.go#L209-L218
Fixes: 390a413 ("Report more Stack info, as stack-mspan-inuse stack-mspan-sys etc. (#63)")
Also adds BuckHashSys mstat and fix inuse to in-use, see commits.