Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix clang tidy modernize-use-equals-default warnings #2952

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

jasjuang
Copy link
Contributor

Prior to the fix using TEST_F will cause clang tidy warnings like

/home/jasjuang/sample/unit-test/SampleTest.cpp:23:1: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
TEST_F(SampleTest, OnePlusOne)
^
/usr/include/gtest/gtest.h:2369:3: note: expanded from macro 'TEST_F'
  GTEST_TEST_(test_fixture, test_name, test_fixture, \
  ^
/usr/include/gtest/internal/gtest-internal.h:1358:58: note: expanded from macro 'GTEST_TEST_'
    GTEST_TEST_CLASS_NAME_(test_suite_name, test_name)() {}                   \
                                                         ^

This PR eliminates this warning.

@derekmauro derekmauro self-assigned this Jul 21, 2020
mbxx added a commit that referenced this pull request Jul 30, 2020
PiperOrigin-RevId: 324016198
mbxx added a commit that referenced this pull request Jul 30, 2020
PiperOrigin-RevId: 324016198
mbxx added a commit that referenced this pull request Jul 31, 2020
PiperOrigin-RevId: 324016198
@mbxx mbxx merged commit e6e2d3b into google:master Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants