Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export Test - Do Not Merge #2541

Closed
wants to merge 19 commits into from
Closed

Export Test - Do Not Merge #2541

wants to merge 19 commits into from

Conversation

vslashg
Copy link
Member

@vslashg vslashg commented Oct 29, 2019

Export Test - Do Not Merge

Merge 1a49b67 into 540835f

Closes #2388

PiotrNycz and others added 14 commits October 22, 2019 15:58
@PiotrNycz
Prevent using ReturnRef on reference to temporary
b11fb80 
Fixed issue: 2471
@PiotrNycz
Added tests verifying that temporaries are accepted by ReturnRef
19a3bbc 
Issue no 2527
@PiotrNycz
Added more tests to verify: ReturnRef not accept temporary
37590da 
Issue 2471
@PiotrNycz
Tests simplified and names corrected (POD->scalar)
d072682 
Issue 2527
@PiotrNycz
Apply 80chars limit
5ff72f5 
Issue 2527
@PiotrNycz
variable names corrected (followed google coding style)
208c2f6 
Issue 2527
@kuzkry
replace autogenerated TypesX classes by variadic ones
eed64b5
@kuzkry
replace autogenerated TemplatesX classes by variadic ones
e3a9a56
@kuzkry
remove gtest-type-util.h.pump
a708356
@kuzkry
move the pumping script to googlemock
002905f
@kuzkry
update CONTRIBUTORS
1a49b67
@vslashg
Merge pull request #2388 from kuzkry:remove-gtest-type-util.pump
8feeead 
PiperOrigin-RevId: 276944601
@vslashg
Export Test - Do Not Merge
17414be 
Remove badly formatted suggestion in gmock cheat sheet.

PiperOrigin-RevId: 277060475
@vslashg
Merge pull request #2527 from PiotrNycz:gmock_prevent_return_ref_to_s…
8173702 
…tore_temporaries_2

PiperOrigin-RevId: 277061341
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@vslashg
Export Test - Do Not Merge
dc6ce64 
Make it clearer that users should _not_ write their own main functions.

PiperOrigin-RevId: 277079721
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

Abseil Team and others added 4 commits October 29, 2019 15:15
@vslashg
Export Test - Do Not Merge
139bc49 
Avoid temporary matcher instances.
They are unnecessary and can be relatively more expensive than the rest of the
algorithm.

PiperOrigin-RevId: 277084853
@vslashg
Export Test - Do Not Merge
d728123 
Editorial cleanup of the "write the main function" section

PiperOrigin-RevId: 277102507
@hermas55 @vslashg
Export Test - Do Not Merge
27322ee 
Merge 65032e2 into 8c91ece

Closes #2470

COPYBARA_INTEGRATE_REVIEW=#2470 from hermas55:bugfix/default_const_param 65032e2
PiperOrigin-RevId: 277118535
@gennadiycivil @vslashg
Export Test - Do Not Merge
4c072d4 
Internal Change

PiperOrigin-RevId: 277336786
@vslashg vslashg closed this Oct 29, 2019
@vslashg vslashg deleted the E5E9B92DC71B262387A82177344D43FD branch October 29, 2019 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: no
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vslashg @googlebot @sbenzaquen @PiotrNycz @kuzkry @hermas55 @gennadiycivil