Skip to content

Commit

Permalink
Fix compiler flags in Linux presubmit
Browse files Browse the repository at this point in the history
CXX_FLAGS should be CXXFLAGS and the quoting was wrong.
As a result, "-Werror -Wdeprecated" was not being applied.

https://cmake.org/cmake/help/latest/envvar/CXXFLAGS.html

PiperOrigin-RevId: 506656655
Change-Id: Ic5e861be3b9c32257eb9aabb845c931f3cba7122
  • Loading branch information
thughes authored and copybara-github committed Feb 2, 2023
1 parent deaf561 commit 2f2e72b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ci/linux-presubmit.sh
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ for cc in /usr/local/bin/gcc /opt/llvm/clang/bin/clang; do
--workdir="/build" \
--rm \
--env="CC=${cc}" \
--env="CXX_FLAGS=\"-Werror -Wdeprecated\"" \
--env=CXXFLAGS="-Werror -Wdeprecated" \
${LINUX_LATEST_CONTAINER} \
/bin/bash -c "
cmake /src \
Expand Down

0 comments on commit 2f2e72b

Please sign in to comment.