-
Notifications
You must be signed in to change notification settings - Fork 870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release native builds #868
Comments
Yeah, this would be nice. Especially as there are now people who distribute native builds themselves elsewhere. Before thinking "release", there should probably be a way to (easily) build it here in this project? So #894 would probably be a pre-requisite here. |
My #1045 will (should, to be tested and confirmed) make a native builds available at the next release cycle! |
And include them in release artifacts. I tested this on my fork of the repo, and have a demo here: https://github.com/cushon/google-java-format/releases When downloading the artifacts from the releases page they don't have the executable bit set, and my Mac blocks them because they aren't signed. That can be worked around with the following, but isn't ideal: ``` chmod a+rx google-java-format-darwin sudo xattr -r -d com.apple.quarantine google-java-format-darwin ``` Progress towards google#868
And include them in release artifacts. I tested this on my fork of the repo, and have a demo here: https://github.com/cushon/google-java-format/releases When downloading the artifacts from the releases page they don't have the executable bit set, and my Mac blocks them because they aren't signed. That can be worked around with the following, but isn't ideal: ``` chmod a+rx google-java-format-darwin sudo xattr -r -d com.apple.quarantine google-java-format-darwin ``` Progress towards google#868
And include them in release artifacts. I tested this on my fork of the repo, and have a demo here: https://github.com/cushon/google-java-format/releases When downloading the artifacts from the releases page they don't have the executable bit set, and my Mac blocks them because they aren't signed. That can be worked around with the following, but isn't ideal: ``` chmod a+rx google-java-format-darwin sudo xattr -r -d com.apple.quarantine google-java-format-darwin ``` Progress towards #868
FYI JoseVSeb/google-java-format-for-vs-code#17 with links to my posts about this:
"Formatting completed in 45ms." instead of 473ms previously... That x10 is actually noticeable on Ctrl-S Save a *.java, even on a fast computer - very cool! @cushon close this issue? |
You can get better results if you compile with profile-guided optimizations (PGO) |
I'm going to close this out for now, PGO sounds worth considering as a follow-up. |
Hello
GraalVM native-image support appears to have been added a little while ago #728 (see also #358). However there are no official native build release on the release page https://github.com/google/google-java-format/releases. is it working ?
Providing these could greatly benefit to java tooling as it would allow fast formatting without having to rely on IDEs customization and while being fully compliant with google style guide. This could be easily imported in Visual Studio Code for example.
Platform targets of most interest would be win32-x64, linux-x64, darwin-x64, darwin-arm64.
The text was updated successfully, but these errors were encountered: