Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App Store rejects binary with "ITMS-90562: Invalid Bundle" #322

Closed
yoasha opened this issue Jan 6, 2020 · 1 comment · Fixed by #323
Closed

App Store rejects binary with "ITMS-90562: Invalid Bundle" #322

yoasha opened this issue Jan 6, 2020 · 1 comment · Fixed by #323

Comments

@yoasha
Copy link

yoasha commented Jan 6, 2020

My iOS app is integrated with google-api library and works great for years now. Yesterday I grabbed the latest google-api sources, archived my app and uploaded to the App Store. Short after got rejection email with the above error.

After several hours of investigation I found that the latest commit of GTLRRuntimeCommon.m is the root cause of the rejection. When skipping this commit, everything goes well.

The rejection appears to be that the App Store can't rebuild the binary from bitcode. And indeed, if I try to archive my app, distribute it to "Development" rather than "App Store Connect", and then choose "Rebuild from Bitcode", Xcode will show a failure.

According to the documentation, one of the reasons for the error is inconsistent usage of "__asm". The latest commit includes the usage of "__asm", so it's only a guess it might be the cause as I'm not familiar with it.

See https://developer.apple.com/library/archive/technotes/tn2432/_index.html#//apple_ref/doc/uid/DTS40017150-CH1-TNTAG3-KNOWN_BITCODE_ISSUES

Any thoughts?
thomasvl added a commit to thomasvl/google-api-objectivec-client-for-rest that referenced this issue Jan 6, 2020
@thomasvl
Revert "Optimize class lookup"
b7ba6b1 
This reverts commit 1de9728.

Looks like the asm tick doesn't fly with bitcode.

Fixes google#322
@thomasvl thomasvl mentioned this issue Jan 6, 2020
Merged
thomasvl added a commit that referenced this issue Jan 6, 2020
@thomasvl
Revert "Optimize class lookup"
ab04ea1 
This reverts commit 1de9728.

Looks like the asm tick doesn't fly with bitcode.

Fixes #322
@thomasvl
Copy link
Member

thomasvl commented Jan 6, 2020

Thanks, rolling back. We'll have to see if we can do this without the asm trick.

@dmaclach dmaclach mentioned this issue Jan 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "Optimize class lookup" thomasvl/google-api-objectivec-client-for-rest
2 participants
@thomasvl @yoasha