Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove embedded cert warning. #98

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Remove embedded cert warning. #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ well-formedness comes from the AMD SEV-SNP API specification, and the
requirements for certificate well-formedness come from the AMD Key Distribution
Service (KDS) specification.

This library embeds AMD's root and SEV intermediate keys
This library embeds AMD's root and SEV intermediate keys' certificates
([AMD source](https://download.amd.com/developer/eula/sev/ask_ark_milan.cert))
for the
[KDS product_name=Milan cert_chain](https://kdsintf.amd.com/vcek/v1/Milan/cert_chain)
Expand Down
2 changes: 0 additions & 2 deletions verify/verify.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ import (
cpb "github.com/google/go-sev-guest/proto/check"
spb "github.com/google/go-sev-guest/proto/sevsnp"
"github.com/google/go-sev-guest/verify/trust"
"github.com/google/logger"
"github.com/pborman/uuid"
"github.com/pkg/errors"
"go.uber.org/multierr"
Expand Down Expand Up @@ -498,7 +497,6 @@ func decodeCerts(chain *spb.CertificateChain, key abi.ReportSigner, options *Opt
return nil, nil, err
}
if len(roots) == 0 {
logger.Warning("Using embedded AMD certificates for SEV-SNP attestation root of trust")
root := &trust.AMDRootCerts{
Product: productName,
// Require that the root matches embedded root certs.
Expand Down
Loading