fix: function asmCpuid missing Go declaration #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deeglaze
requested changes
Sep 20, 2023
abi/cpuid_amd64.s
Outdated
| @@ -14,8 +14,8 @@ | |||
|
|
|||
| //+build amd64,!gccgo | |||
|
|
|||
| // func asmCpuid(op uint32) (eax, ebx, ecx, edx uint32) | |||
| TEXT ·asmCpuid(SB), 7, $0 | |||
There was a problem hiding this comment.
Please revert name change.
|
@deeglaze Thank you for your detailed guidance. I have made another revision, please take a look. |
deeglaze
requested changes
Sep 21, 2023
- Added new files `abi/cpuid_amd64.go` and `abi/cpuid.go` - Implemented the `asmCpuid` function in the `abi` package - Added tests for the `cpuid` function in `abi/abi_test.go`
deeglaze
requested changes
Sep 21, 2023
|
@deeglaze done |
deeglaze
approved these changes
Sep 21, 2023
Thank you for your patient guidance 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got this error, maybe misspell the function's name?
Append: also add a
cpuid.gofile to compatable with non-amd64 machine that could also import this package