fix: Use reported TCB when fetching VCEK #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Moritz Sanft <[email protected]>
3 tasks
deeglaze
approved these changes
Aug 31, 2023
|
Thanks for the report and fix! |
|
No fixed schedule. I've cut v0.7.1 for you.
…On Thu, Aug 31, 2023 at 10:59 PM Moritz Sanft ***@***.***> wrote:
Hey @deeglaze <https://github.com/deeglaze>, thank you so much for the
quick approval. Is there a fixed schedule for releases? If not, is there
any chance you could trigger a new release soon?
—
Reply to this email directly, view it on GitHub
<#73 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFL4HCQLFXW7GVN4CUE4MDXYF2TXANCNFSM6AAAAAA4F5ATGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Change
Use the ReportedTCB when querying the AMD KDS for the VCEK certificate, as per the specification:
Additional Info
I've added no tests regarding this, since I don't know how a test could look like without adding additional testdata. If you are fine with adding additional testdata, I can add a test for the case of an report with mismatching
CurrentTCBandReportedTCB, which should trigger the bug from the issue mentioned below.This fixes #72