Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency glog leaks go routine #23

Closed
3u13r opened this issue Oct 28, 2022 · 1 comment · Fixed by #24
Closed

Dependency glog leaks go routine #23

3u13r opened this issue Oct 28, 2022 · 1 comment · Fixed by #24
Assignees
@deeglaze

Comments

@3u13r
Copy link

3u13r commented Oct 28, 2022

Using go-tpm-tools/client introduces go-sev-guest/abi as dependency. This in turn depends on glog which leaks as shown below. Sadly, glog is also unmaintained, so there's no way for us to provide a fix. Is it possible to replace glog with klog? The interface seems to be similar.

goleak: Errors on successful test run: found unexpected goroutines:
[Goroutine 19 in state chan receive, with github.com/golang/glog.(*loggingT).flushDaemon on top of the stack:
goroutine 19 [chan receive]:
github.com/golang/glog.(*loggingT).flushDaemon(0x0?)
	/home/euler/go/pkg/mod/github.com/golang/[email protected]/glog.go:882 +0x6a
created by github.com/golang/glog.init.0
	/home/euler/go/pkg/mod/github.com/golang/[email protected]/glog.go:410 +0x1bf
deeglaze added a commit to deeglaze/go-sev-guest that referenced this issue Oct 28, 2022
@deeglaze
Change glog dependency to klog
fc13e5f 
glog is unmaintained, but the klog fork is.
Fixes google#23

Signed-off-by: Dionna Glaze <[email protected]>
@deeglaze deeglaze mentioned this issue Oct 28, 2022
Merged
@deeglaze
Copy link
Collaborator

Thanks for your report. Will change to klog.

@deeglaze deeglaze self-assigned this Oct 28, 2022
@3u13r 3u13r mentioned this issue Oct 29, 2022
Merged
deeglaze added a commit to deeglaze/go-sev-guest that referenced this issue Nov 2, 2022
@deeglaze
Change glog dependency to klog
2f5e6f4 
glog is unmaintained, but the klog fork is.
Fixes google#23

Signed-off-by: Dionna Glaze <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeglaze deeglaze

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change glog dependency to klog deeglaze/go-sev-guest
2 participants
@deeglaze @3u13r