feat: implement std.round #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitjangid
force-pushed
the
feat/math-round
branch
2 times, most recently
from
de15d34
to
db0f540
Compare
rohitjangid
force-pushed
the
feat/math-round
branch
from
db0f540
to
345dece
Compare
|
@sparkprime Can you help me understand why these checks are failing? By looking at error messages, it looks like it something is failing in go sdk. |
|
there's something going on but also i think there's a trailing newline diff with your golden files. |
pawelbeza
added a commit
to pawelbeza/jrsonnet
that referenced
this pull request
Jul 14, 2023
Upstream issue: google/go-jsonnet#683
vhata
pushed a commit
to discord/go-jsonnet
that referenced
this pull request
Aug 30, 2024
Co-authored-by: Dave Cunningham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
std.roundfunction in standard library.PR for jsonnet: google/jsonnet#1064