Allow use of "go-jsonnet" Bazel repository as an external dependency #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't get the full Bazelology, but it looks reasonable. |
seh
referenced
this pull request
in davidzchen/cue
Jan 13, 2020
Generated with the following commands: ```sh bazel run //:gazelle -- update-repos -from_file=go.mod bazel run //:gazelle ``` Tested by successfully building the `cue` binary: ```sh bazel build //cmd/cue ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to rely on the go-jsonnet Bazel repository as an external dependency from other Bazel projects, until it becomes possible to load a WORKSPACE file, it's necessary to first declare the repositories on which this repository depends (rules_go and gazelle), and then to load file from those two repositories and call macros to initialize them.
Expose two files to handle these steps:
Defines the
jsonnet_go_repositoriesmacro.Defines the
jsonnet_go_dependenciesmacro.Use these files and the macros they define within this repository's WORKSPACE file, as a dependent repository would do in its WORKSPACE file.