Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Add sliceofpointers custom linter #3447

Merged
merged 10 commits into from
Jan 22, 2025

Conversation

gmlewis
Copy link
Collaborator

@gmlewis gmlewis commented Jan 21, 2025

BREAKING CHANGE: ListOAuthApps now returns ([]*OAuthApp, error) instead of ([]OAuthApp, error).

This PR should help developers use a consistent style by not writing []*string or []T in their PRs.
It should also ease the maintenance burden by not having to repeat this over and over again.

@gmlewis gmlewis marked this pull request as draft January 21, 2025 19:55
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.03%. Comparing base (27bd175) to head (15174df).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3447   +/-   ##
=======================================
  Coverage   91.03%   91.03%           
=======================================
  Files         179      179           
  Lines       15532    15532           
=======================================
  Hits        14139    14139           
  Misses       1221     1221           
  Partials      172      172           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Glenn Lewis <[email protected]>
.custom-gcl.yml Outdated Show resolved Hide resolved
gmlewis and others added 2 commits January 21, 2025 16:19
Co-authored-by: Ludovic Fernandez <[email protected]>
Signed-off-by: Glenn Lewis <[email protected]>
@gmlewis gmlewis marked this pull request as ready for review January 22, 2025 01:06
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Jan 22, 2025
@gmlewis gmlewis changed the title Add sliceofpointers custom linter chore!: Add sliceofpointers custom linter Jan 22, 2025
@gmlewis gmlewis added the Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). label Jan 22, 2025
Signed-off-by: Glenn Lewis <[email protected]>
@gmlewis gmlewis changed the title chore!: Add sliceofpointers custom linter chore!: Add sliceofpointers custom linter Jan 22, 2025
@gmlewis
Copy link
Collaborator Author

gmlewis commented Jan 22, 2025

@stevehipwell - do you have time for a code review? Thank you!

@ldez
Copy link
Contributor

ldez commented Jan 22, 2025

I'm curious: what is the reasoning behind using slice of pointer of struct inside of slice of struct?

@gmlewis
Copy link
Collaborator Author

gmlewis commented Jan 22, 2025

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Jan 22, 2025
@gmlewis
Copy link
Collaborator Author

gmlewis commented Jan 22, 2025

Thank you, @ldez!
Merging.

@gmlewis gmlewis merged commit 07b0446 into google:master Jan 22, 2025
7 checks passed
@gmlewis gmlewis deleted the add-no-pointer-to-string-slice branch January 22, 2025 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants