-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: Add sliceofpointers
custom linter
#3447
chore!: Add sliceofpointers
custom linter
#3447
Conversation
Signed-off-by: Glenn Lewis <[email protected]>
Signed-off-by: Glenn Lewis <[email protected]>
…inter Signed-off-by: Glenn Lewis <[email protected]>
Signed-off-by: Glenn Lewis <[email protected]>
Signed-off-by: Glenn Lewis <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3447 +/- ##
=======================================
Coverage 91.03% 91.03%
=======================================
Files 179 179
Lines 15532 15532
=======================================
Hits 14139 14139
Misses 1221 1221
Partials 172 172 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Glenn Lewis <[email protected]>
Co-authored-by: Ludovic Fernandez <[email protected]>
Signed-off-by: Glenn Lewis <[email protected]>
Signed-off-by: Glenn Lewis <[email protected]>
sliceofpointers
custom linter
@stevehipwell - do you have time for a code review? Thank you! |
I'm curious: what is the reasoning behind using slice of pointer of struct inside of slice of struct? |
|
Thank you, @ldez! |
BREAKING CHANGE:
ListOAuthApps
now returns([]*OAuthApp, error)
instead of([]OAuthApp, error)
.This PR should help developers use a consistent style by not writing
[]*string
or[]T
in their PRs.It should also ease the maintenance burden by not having to repeat this over and over again.