Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add enterprise custom properties #3382

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

stevehipwell
Copy link
Contributor

This PR adds enterprise scoped custom properties.

Note

This API endpoint is currently still in preview.

@gmlewis gmlewis changed the title feat: Added enterprise custom properties feat: Add enterprise custom properties Dec 11, 2024
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.31%. Comparing base (2b8c7fa) to head (741a8db).
Report is 198 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3382      +/-   ##
==========================================
- Coverage   97.72%   92.31%   -5.42%     
==========================================
  Files         153      177      +24     
  Lines       13390    15099    +1709     
==========================================
+ Hits        13085    13938     +853     
- Misses        215     1068     +853     
- Partials       90       93       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @stevehipwell - this looks great!
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Dec 11, 2024
Copy link
Contributor

@tomfeigin tomfeigin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Dec 12, 2024
@gmlewis
Copy link
Collaborator

gmlewis commented Dec 12, 2024

Thank you, @tomfeigin !
Merging.

@gmlewis gmlewis merged commit 7bc4871 into google:master Dec 12, 2024
6 of 7 checks passed
@stevehipwell stevehipwell deleted the add-enterprise-properties branch December 12, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants