Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Remove Project (classic) support #3380

Merged
merged 2 commits into from
Dec 11, 2024
Merged

feat!: Remove Project (classic) support #3380

merged 2 commits into from
Dec 11, 2024

Conversation

gmlewis
Copy link
Collaborator

@gmlewis gmlewis commented Dec 10, 2024 •
edited
Loading

BREAKING CHANGE: All support for "Project (classic)" is removed and Project responses are replaced by ProjectV2 (renamed from ProjectsV2).

Fixes: #3367.

@codecov Codecov
Copy link

codecov bot commented Dec 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.17%. Comparing base (2b8c7fa) to head (4757698).
Report is 195 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3380      +/-   ##
==========================================
- Coverage   97.72%   92.17%   -5.55%     
==========================================
  Files         153      172      +19     
  Lines       13390    14704    +1314     
==========================================
+ Hits        13085    13554     +469     
- Misses        215     1060     +845     
  Partials       90       90

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewis gmlewis mentioned this pull request Dec 10, 2024
Closed
@gmlewis gmlewis added NeedsReview PR is awaiting a review before merging. Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). labels Dec 10, 2024
stevehipwell
stevehipwell approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis
Copy link
Collaborator Author

gmlewis commented Dec 10, 2024

Thank you, @stevehipwell !

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

tomfeigin
tomfeigin approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@tomfeigin tomfeigin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Dec 11, 2024
@gmlewis
git merge master
4757698 
Signed-off-by: Glenn Lewis <[email protected]>
@gmlewis
Copy link
Collaborator Author

gmlewis commented Dec 11, 2024

Thank you, @tomfeigin !
Merging.

@gmlewis gmlewis merged commit 550ecbe into google:master Dec 11, 2024
6 of 7 checks passed
@gmlewis gmlewis deleted the i3367-remove-projects branch December 11, 2024 13:45
@gmlewis gmlewis mentioned this pull request Dec 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomfeigin tomfeigin tomfeigin approved these changes

@stevehipwell stevehipwell stevehipwell approved these changes

Assignees
No one assigned
Labels
Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove projects as the REST API for these is no longer available
3 participants
@gmlewis @stevehipwell @tomfeigin