Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SAML SSO authorization APIs #2835

Merged
merged 4 commits into from
Jul 24, 2023

Conversation

joaopenteado
Copy link
Contributor

This PR adds support for both ListCredentialAuthorizations and RemoveCredentialAuthorization methods available for the GitHub Enterprise Cloud REST API for SAML SSO authorizations.

Listing and deleting credential authorizations is available to organizations with GitHub Enterprise Cloud.

@joaopenteado joaopenteado changed the title Added support for SAML SSO authorization APIs Add support for SAML SSO authorization APIs Jul 20, 2023
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @joaopenteado !
Just a few tweaks, please, then we will be ready for a second LGTM+Approval from any other contributor to this repo before merging.

github/orgs_credential_authorizations.go Show resolved Hide resolved
github/orgs_credential_authorizations_test.go Show resolved Hide resolved
github/orgs_credential_authorizations.go Outdated Show resolved Hide resolved
github/orgs_credential_authorizations.go Outdated Show resolved Hide resolved
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Jul 20, 2023
@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #2835 (529eb79) into master (b02bb75) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2835   +/-   ##
=======================================
  Coverage   98.06%   98.06%           
=======================================
  Files         137      138    +1     
  Lines       12291    12314   +23     
=======================================
+ Hits        12053    12076   +23     
  Misses        162      162           
  Partials       76       76           
Impacted Files Coverage Δ
github/orgs_credential_authorizations.go 100.00% <100.00%> (ø)

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @joaopenteado !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@joaopenteado
Copy link
Contributor Author

Thank you for the fast review and comments as always, @gmlewis!
I just committed a improvement to the test for ListCredentialAuthorizations in order to match what was being done in other functions.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, @joaopenteado ! Thank you very much!
I was wondering why the coverage dropped, but it looks like you found it and fixed it!
🎉

@o-sama
Copy link
Contributor

o-sama commented Jul 23, 2023

LGTM too :)

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Jul 24, 2023
@gmlewis
Copy link
Collaborator

gmlewis commented Jul 24, 2023

Thank you, @o-sama !
Merging.

@gmlewis gmlewis merged commit a3dc9cb into google:master Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants