-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support repository_id in org ruleset conditions #2825
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov Report
@@ Coverage Diff @@
## master #2825 +/- ##
=======================================
Coverage 98.06% 98.06%
=======================================
Files 136 136
Lines 12279 12279
=======================================
Hits 12041 12041
Misses 162 162
Partials 76 76
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @ysoldak !
Just a few tweaks, please, then we will be ready for a second LGTM+Approval before merging.
Please also update the unit tests so that |
Co-authored-by: Glenn Lewis <[email protected]>
🤦 PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @ysoldak !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
Thanks, @gmlewis I thought worth to reference GitHub's own statement about API change: The part this PR addresses is "Added a repository picker to target select repositories for organization rulesets." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you, @liaodaniel ! |
This PR adds support for referencing repositories by ID in Ruleset conditions.
See https://docs.github.com/en/rest/orgs/rules?apiVersion=2022-11-28#create-an-organization-repository-ruleset
API is changed a bit, probably a low impact since v53.2.0 (with ruleset support added) was released just recently and hopefully not many have code using it in production.
The change
RulesetRepositoryConditionParameters
->RulesetRepositoryNamesConditionParameters
I'm open for suggestions for a change that would not shake the API.