-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LockBranch and AllowForkSyncing to repos.go #2577
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After making the requested changes below, please run gofmt
on repos.go
and then also run go generate ./...
at the top of the repo and push (not force-push) any changes that were made, as described in the file CONTRIBUTING.md.
Thanks.
Co-authored-by: Glenn Lewis <[email protected]>
I can't seem to replicate the failing test in my local environment, already ran |
From checking the workflow file. The tests didnt run. Its failing at the go-github/.github/workflows/tests.yml Line 64 in 621c4ba
specifically at edit: @XaurDesu
|
Yes, you are correct, @dtdao - thank you for the detailed explanation. This information should also be covered in our CONTRIBUTING.md guide at the top of this repo... if you feel that it can be made clearer, we welcome PRs for it as well. |
I agree that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @XaurDesu !
LGTM.
Merging.
Codecov Report
@@ Coverage Diff @@
## master #2577 +/- ##
=======================================
Coverage 97.98% 97.98%
=======================================
Files 125 125
Lines 10875 10875
=======================================
Hits 10656 10656
Misses 150 150
Partials 69 69
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Fixes #2574 , and it is mostly a direct, if barebones, implementation of the plan ideated there. Adding references to
LockBranch
andAllowForkSyncing
. References toRequireLastPushApproval
were added in cb24cab . There might be some changes left to do.